[Django]-Showing error messages in template in DefaultUserCreationForm – django

by

4👍

✅

The problem is in this line :

if(form.is_valid):

This is not the correct way of testing form validation,
instead use:

if form.is_valid():

Also you dont need to declare form multiple times,it can be done single time.
Like this :

def adduser(request):
    form = UserCreationForm(request.POST or None)
    if request.method == 'POST':
        print(request.POST)
        if form.is_valid():
            try:
                user = employees.objects.get(emp_id=request.POST['username'] )
            except employees.DoesNotExist:
                user = None

            print(user)
            if( user != None ):
                if request.POST['username'] in  employees.objects.values_list('manager_id__emp_id',flat=True):
                    g = Group.objects.get(name='Managers')
                    newuser = form.save()
                    newuser.groups.add(g)
                else:
                    g = Group.objects.get(name='Employees')
                    newuser = form.save()
                    newuser.groups.add(g)

                return render(request,'login.html',{'form': form})
            else:
                form = UserCreationForm()
                return render(request,'signup.html', {'form': form, 'msg': 'Enter valid employee id'})
    return render(request,'signup.html', {'form': form})

And there can be diffrenmt type of erros, field and non_field_errors, so use someting like this :

{% if form.errors %}
    {% for field in form %}
        {% for error in field.errors %}
            <div class="alert alert-danger">
                <strong>{{ error|escape }}</strong>
            </div>
        {% endfor %}
    {% endfor %}
    {% for error in form.non_field_errors %}
        <div class="alert alert-danger">
            <strong>{{ error|escape }}</strong>
        </div>
    {% endfor %}
{% endif %}
👤Prakhar Trivedi

Leave a comment