[Django]-Django Forms:Post request is got but data is not saved

by

2👍

✅

It’s a suprise that this code runs at all, it should be producing attribute errors for these:

    user.discord = request.discord
    user.reddit = request.reddit

But the reason that it doesn’t is because the execution path never reaches that point

def formtofill(request):
   form = Application() 
   return render(request, 'appmod.html', {'form': form,})

Because of that return statement.

Your corrected code should look like

def formtofill(request):

    form = Application() 

    if request.method == "POST":
        form = Application(request.POST)
        print(request.POST)
        if form.is_valid():
            user = form.save()
            messages.success(request, 'Your Mod Application has been successfully submitted!')
            return HttpResponseRedirect('/success_url')
    else:
       form_class = Application
    return render(request, 'appmod.html', {'form': form,})
👤e4c5

1👍

Dont save the form upfront. Save but put commit=false.
Also remove that return statement as in the answer above mine.

user = form.save(commit=False).

Then an instance is created, but its not written into the database. Now you can do the assignments.

    user = form.save(commit=False).
    #Now....
    user.discord = request.POST['discord']
    user.reddit = request.POST['reddit']
    user.serverrank = request.POST['serverrank']
    user.finds = request.POST['finds']
    user.serverstay = request.POST['serverstay']
    ....................
    user.save()
    return HttpResponse('Successful')

Instead you were trying to access the data as an attribute of the request object itself. The form data are contained in request.POST, then you have to access it from there.

Also, 

else:
    form = Application()

You need to instantiate the form class.

👤zaidfazil

Leave a comment