[Answer]-Django does not match urls

by

1👍

✅

I’m not exactly sure what was happening since all of my templates linked to other pages using the {% url %} tag, but I think the reason my urls were getting muddled up was because I was using the r’^(\w+)/$’ regex, so it was matching any word. I simply moved the urlconfs with the (\w+) rule to the bottom of urls.py, and refactored them to be a little more specific and they were gold again.

The updated urlconf:

from django.conf import settings
from django.conf.urls.defaults import patterns, include, url
from django.contrib.auth.decorators import login_required


from store import views


admin_urls = patterns ('',
)


urlpatterns = patterns ('',
    url(r'^category/$', views.get_brands, name='get_brands'),
    url(r'^(\w+)/$', views.GalleryView.as_view(), name='gallery'),
    url(r'^(\w+)/(\w+)/$', views.GalleryView.as_view(), name='gallery'),

    url(r'^login/$', views.admin_login, name='login'),
    url(r'^logout/$', views.admin_logout, name='logout'),
    url(r'^logout/success/$', views.admin_logout_success, name='logout_success'),

    url(r'^ajax/$', views.ajax_request, name='ajax_request'),
    url(r'^administration/$', login_required(views.AdminIndexView.as_view()), name='admin_index'),
    url(r'^administration/add/(\w+)/$', login_required(views.AdminAddView.as_view()), name='admin_add'),
)
👤lptorres

0👍

As you mentioned in the comments, removing login_required fixes the problem. Here’s what the django docs have to say about the decorator:

login_required() does the following:

  1. If the user isn’t logged in, redirect to settings.LOGIN_URL, passing the current absolute path in the query string. Example:
    /accounts/login/?next=/polls/3/.
  2. If the user is logged in, execute the view normally

[…] Note that if you don’t specify the login_url parameter, you’ll
need to map the appropriate Django view to settings.LOGIN_URL.

In other words, it goes to a default url you can override in settings.LOGIN_URL.

Now here’s what I think happened – I think you defined your own login here:

url(r'^login/$', views.admin_login, name='login'),

And because the login_required in the new urls pointed at the default url, which doesn’t exist it returned 404. However, when you configured the login_required views after your other urls:

url(r'^login/$', views.admin_login, name='login'),
...
url(r'^administration/$', login_required(views.AdminIndexView.as_view()), name='admin_index'),
url(r'^administration/add/(\w+)/$', login_required(views.AdminAddView.as_view()), name='admin_add'),

it worked. Why is that? You didn’t overrid LOGIN_URL here right? But you sort of did – because at this point, you redefined the namespace ‘login’ to point to your own view. Now this isn’t mentioned anywhere in the docs, but it makes sense, and looking at the default admin templates you can see this is the namespace being used.

Does that make sense to you?

👤yuvi

Leave a comment